fix: Propagate uvicorn logs #1250
Merged
+112
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
==========================================
+ Coverage 94.73% 94.75% +0.02%
==========================================
Files 41 41
Lines 2638 2668 +30
==========================================
+ Hits 2499 2528 +29
- Misses 139 140 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Looks good, so much more consistent
|
DiamondJoseph
approved these changes
Oct 30, 2025
|
I struggled to get examples of non-INFO logs, we should make sure some of our obvious use cases that I tried log errors (e.g. searching for a plan that doesn't exist etc.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs produced by Uvicorn's internals and blueapi are currently processed by different handlers. Due to this nothing produced by Uvicorn is being propagated to Graylog.
This PR relegates handling of Uvicorn logs to BlueAPI's handlers and standardises terminal formatting.
Fixes #1248